search

microsoft / vscode-languageserver-node

Language server protocol implementation for VSCode. This allows implementing language services in JS/TS running on node.js
MIT License
1.45k stars 325 forks source link

Allow resultReporter to be substituted in provideWorkspaceDiagnostics middleware. #1561

Closed JoeRobich closed 2 days ago

JoeRobich commented 5 days ago

By not accepting a resultReporter parameter in provideDiagnostics the provideWorkspaceDiagnostics middleware always used the reporter it was initially passed. This means that diagnostics are always reported without the ability to manipulate them first.

JoeRobich commented 5 days ago

@dbaeumer You were suggested as someone who might could review this. We are looking at allowing C# users to optionally turn information diagnostics into hint diagnostics and this is blocking us.

dbaeumer commented 5 days ago

@JoeRobich great catch.