microsoft / vscode-powerquery

Visual Studio Code extension for Power Query / M.
MIT License
88 stars 18 forks source link

[BUG] Excel.CurrentWorkbook raises UnknownIdentifier error #180

Closed CABrinegar closed 10 months ago

CABrinegar commented 2 years ago

Expected behavior Excel.CurrentWorkbook should be recognized as a valid identifier.

Actual behavior Using Excel.CurrentWorkbook raises the following error: Cannot find the name 'Excel.CurrentWorkbook', did you mean 'Excel.Workbook'? powerquery(Error.UnknownIdentifier)

To Reproduce Example script:

let
    foo = Excel.CurrentWorkbook()
in
    foo

Additional context This function is documented at https://learn.microsoft.com/en-us/powerquery-m/excel-currentworkbook

CABrinegar commented 2 years ago

Fixed by PR https://github.com/microsoft/vscode-powerquery/pull/181

mattmasson commented 1 year ago

Thanks - we use an automated (internal) process to dump the symbols and produce these files, so I don't think we'll merge PR #181. But we'll fix the bug that was preventing Excel.CurrentWorkbook from being emitted along with the other symbols.

PJSoftware commented 1 year ago

I am also waiting on this issue to be resolved -- or I was, a couple of months back when I first found it. Another symbol I'm using which has the same problem is:

Cannot find the name 'AutodeskConstructionCloud.Contents'.powerquery(Error.UnknownIdentifier)

I'm sure the resolution will be the same, but I'm adding it here so you have an additional symbol to test for when fixing your symbol-dumping bug. (That said, I note that AutodeskConstructionCloud does not appear to be documented at https://learn.microsoft.com/en-us/powerquery-m, possibly because it is still in Beta? (As is ACC itself.))

patlachance commented 1 year ago

Thanks - we use an automated (internal) process to dump the symbols and produce these files, so I don't think we'll merge PR #181. But we'll fix the bug that was preventing Excel.CurrentWorkbook from being emitted along with the other symbols.

@mattmasson any idea of when it could be fixed?

mattmasson commented 10 months ago

tracked by #206