search

microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.3k stars 574 forks source link

Clean up TODO comment after issue closed #1964

Open sana-ajani opened 4 years ago

sana-ajani commented 4 years ago

From Twitter: https://twitter.com/alvaromartmart/status/1278759499894054912

Not sure if we can remove the TODO, but that would be helpful to "close the loop". Perhaps we could trigger the code action again reminding users it's still there?

egamma commented 4 years ago

We could validate that a TODO still applies when it is open in an editor. The validation would check whether the issue is still open, if it is closed we could squiggle the TODO with a diagnostic warning.