search

microsoft / vscode-test-web

Node module to help testing VS Code web extensions.
MIT License
60 stars 23 forks source link

Clamp VSCode download to stable release until NLS issue on Insiders is fixed #129

Closed mihailik closed 3 months ago

mihailik commented 4 months ago

Currently launching VSCode leads to partial crash and unusuable state (mount issues and NLS-related logs in DevTools console).

Root cause indicated by VSCode team suggest latest changes in NLS might have affected it.

Switching from "insider" to "stable" version download fixes the problem.

This PR clamps the version to "stable" and unblocks vscode-test-web functionality again.

The intention is to figure out the necessary change either in vscode-test-web codebase, or in the VSCode itself, while the core functionality is back to working.

See https://github.com/microsoft/vscode/issues/220171 for details of the issue.

mihailik commented 4 months ago

Note that if the bug is not fixed either in this repo, or the main VSCode, it'll start breaking again when NLS changes from 1.92.0-insider hit stable (which is currently 1.91.0).

Given that 1.91.0 has literally just gone out, there's a month to fix it.

aeschli commented 3 months ago

https://github.com/microsoft/vscode/issues/220171 got fixed