microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.88k stars 29.52k forks source link

color picker resets back to old color on save #105201

Closed hiredtocode closed 4 years ago

hiredtocode commented 4 years ago

Steps to Reproduce:

  1. Open Code > settings.json
  2. semanticTokenColorCustomizations > change color > save.

As soon as you save, the color picker mouse pointer "resets" to the previous color.

Please note that workbench.colorCustomizations > change color > save works fine.

Does this issue occur when all extensions are disabled?: Yes

vscodebot[bot] commented 4 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

hiredtocode commented 4 years ago

@vscodebot Nope, it's a different bug.

aeschli commented 4 years ago

@hiredtocode Sorry, the steps are too compressed. What do you mean by Open Code > settings.json > F5 and semanticTokenColorCustomizations > change color > save. What is the the color picker mouse pointer? Maybe add some screenshots to clarify. Thanks!

hiredtocode commented 4 years ago

@aeschli I was trying to make screenshots and create a reply but it was a bit comber-sum so I decided to make a short video so it's clear for both of us to diagnose this bug. Here's the link : https://youtu.be/q-JCOE5hKu4 Let me know if it's not clear. Thanks.

aeschli commented 4 years ago

@hiredtocode Thanks a lot for the video! I can reproduce the issue.

aeschli commented 4 years ago

@rebornix Seems to be an issue with the color picker:

Looking at the JSON Language Server log:

github-actions[bot] commented 3 years ago

This bug has been fixed in to the latest release of VS Code Insiders!

@hiredtocode, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version f4187f22026ff6537f2ca8132ad3209fceb5071f of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

rzhao271 commented 3 years ago

Nvm, verified it locally, sorry about that