microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.49k stars 29.37k forks source link

When work with Sogou pinyin Chinese input method, the inputed Chinese word will repeat. #10937

Closed Ruikuan closed 8 years ago

Ruikuan commented 8 years ago

Steps to Reproduce:

  1. Download Sogou pinyin Chinese input method. It's a very popular Chinese input method, almost top 1, so I think maybe this issue will puzzle many people. download
  2. Install the input method, then use it to input any Chinese word, you can see the word will be repeated in the Editor.
    inputing inputed
fantacytyx commented 8 years ago

QQ pinyin have the same problem.

I think the problem is caused by the space image animation

alexdima commented 8 years ago

@Ruikuan @fantacytyx Can you please try today's insiders version, where we made a fix in this area for mac dead key handling (input was doubled), I believe that fix might fix this issue too.

image

alexdima commented 8 years ago

The relevant commit is 26f5824005d31dffebd1235dc997088f7ee76754

fantacytyx commented 8 years ago

@alexandrudima This issue has been fixed. But I find a new problem that the chars of the input is difficult to undo by using keyboard Ctrl+z.

alexdima commented 8 years ago

@fantacytyx Thank you for confirming. Indeed, let's track the undo problem in #9675

Ruikuan commented 8 years ago

@alexandrudima, Issue fixed. Thank you.

alexdima commented 8 years ago

@Ruikuan @fantacytyx I have started some time ago a Wiki page where we collect different manual tests for different input methods. Please notice how the tests are written "for dummies" with all the needed steps spelled out.

https://github.com/Microsoft/vscode/wiki/IME-Test

Is it possible that maybe you comment in here such a test for the Sogou pinyin Chinese input method. I can then take it from here and add it to the wiki, such that in the future when we make changes in this area we can also test this input method? [There is already a test for Microsoft Pinyin, maybe we can add one for Sogou too, it looks like they behave differently at the OS level)

Ruikuan commented 8 years ago

Hope this can be helpful.

alexdima commented 8 years ago

@Ruikuan Thank you very much! :heart: I have added this as a test to the wiki!

https://github.com/Microsoft/vscode/wiki/IME-Test#windows-sogou-pinyin-chinese-input-method