search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.88k stars 28.75k forks source link

Custom dialog should have max height #114662

Open usernamehw opened 3 years ago

usernamehw commented 3 years ago

Settings:

"window.dialogStyle": "custom",

Extension code:

vscode.window.showInformationMessage('aaaaa\n'.repeat(100), { modal: true });

Screenshot (425)

It should behave like a native modal (having a scrollbar to be able to see all the text and buttons).

usernamehw commented 3 years ago

This is not a duplicate of #87266, since that issue is for native modal and this is for custom one.

davidkjackson54 commented 3 years ago

Is there any update on the progress of this fix? The lack of a scrollbar for custom dialog is a real headache.

usernamehw commented 3 years ago

cc @sbatten This issue is missing labels, maybe it was missed?

davidkjackson54 commented 3 years ago

I think that what would be useful is to allow the number of lines to be specified and then provide a scroll bar should it exceed the number of specified lines plus the usual buttons at the bottom.

bpasero commented 5 months ago

At least on macOS, even native dialogs behave like that 🤔

image