search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
165.18k stars 29.62k forks source link

Nested git repo detection for symlinked repo #173766

Closed lonix1 closed 16 hours ago

lonix1 commented 1 year ago

A few months ago we got a new feature for detecting nested git repos: feature, PR.

But it doesn't handle the use case where the repo is in a symlinked directory. We have a number of common repos used in many monorepos, and they're referenced as symlinks:

MyMonoRepo/
  .git/
  lib/
    NormalNestedRepo/                  <--- detected
      .git/
    SymlinkedNestedRepo/               <--- not detected
      .git/
  src/

The symlinked repo is not detected.

(Unless this is already supported somehow @lszomoru @nteymory ?)

lszomoru commented 1 year ago

@lonix1, apologies for not getting back to you on this until now. There are several features (https://github.com/microsoft/vscode/issues/5970) that are not working as expected when there is a symbolic link on the path of the git repository. I expect that this is something that we will look at when we try to tackle the symbolic link support.

lszomoru commented 16 hours ago

@lonix1, are you still able to reproduce this issue? Since the issue was last updated we have made more improvements in this area. I will go ahead and optimistically close this issue but in case you are still able to reproduce this, please feel free to reopen it. Thanks!