Closed benibenj closed 1 year ago
Verification steps:
Set workbench.editor.showTabs: multiple
tabActionLocation
from right to left: unpin and close actions on the tab should move to the left of the file nametabActionUnpinVisibility
setting, the unpin action on pinned tabs do not show anymore. The close action shows instead (on hover)tabActionCloseVisibility
setting, the close actions does not show anymore on the tabs.
When using
workbench.editor.pinnedTabsOnSeparateRow
user might not want to have the unpin action but the close action. We considered not showing the unpin action when using the pinned tab row by default without adding a setting, however, in the case when the user only has pinned tabs there is only one row and it can be unclear if all tabs are pinned or unpinned. Users might also not want to see the unpin action when using a single tab row, so it make sense to add a setting. My suggestion is to have the following settings:tabActionLocation: ['left', 'right']
tabActionCloseVisibility
: booleantabActionUnpinVisibility
: booleantabActionLocation
defines the location of the actions on the tab. If a tab is pinned andtabActionUnpinVisibility
is set tofalse
, we show the close action as long astabActionCloseVisibility
is set totrue
, otherwise we don't show it.Thanks to @n-gist for suggesting a similar approach and creating a PR for it: #196896