microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.85k stars 29.5k forks source link

Release notes - clicking on a setting link open setting as a new tab in current editor group #207218

Open vanowm opened 8 months ago

vanowm commented 8 months ago

Type: Bug

When release notes opened in a separate editor group, clicking on a setting link opens settings tab in the same group where release notes is, even if settings tab was already opened in another group.

How to reproduce: Open settings tab and release notes. Drag release notes into separate group (right), leaving settings in left group Now you have both settings and release notes opened on screen at the same time. In release notes find a link to a setting, click it and select "View xx in Settings". Instead of showing the setting in left group, it opens a new tab in right group.

This is an unwanted behaviour, bucause of bug #168677 switching back to release notes tab it schanges scroll position.

VS Code version: Code 1.87.1 (1e790d77f81672c49be070e04474901747115651, 2024-03-06T00:21:36.258Z) OS version: Windows_NT x64 10.0.19045 Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|63.86GB (34.26GB free)| |Process Argv|--verbose| |Screen Reader|no| |VM|50%|
Extensions (92) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 vscode-javascript-repl|ach|0.7.4 vscode-userscript|adp|1.3.2 Bookmarks|ale|13.4.2 tsl-problem-matcher|amo|0.6.2 vscode-scriptmonkey|and|0.0.8 browse-lite|ant|0.3.8 vite|ant|0.2.5 chronicler|arc|0.1.16 vscode-log-viewer|ber|0.14.1 github-markdown-preview|bie|0.3.0 markdown-checkbox|bie|0.4.0 markdown-emoji|bie|0.3.0 markdown-footnotes|bie|0.1.1 markdown-mermaid|bie|1.22.0 markdown-preview-github-styles|bie|2.0.3 markdown-yaml-preamble|bie|0.1.0 vscode-intelephense-client|bme|1.10.2 git-exclude|bou|0.3.1 phpserver|bra|3.0.2 insert-unicode|bru|0.15.1 turbo-console-log|Cha|2.10.4 ascii-table-fork|Coo|1.1.0 jsdoc-generator|cry|2.0.2 autoit|Dam|1.0.12 vscode-eslint|dba|2.4.4 xml|Dot|2.5.1 gitlens|eam|14.9.0 vscode-html-css|ecm|2.0.9 EditorConfig|Edi|0.16.4 vscode-great-icons|emm|2.1.102 prettier-vscode|esb|10.1.0 vscode-macros|EXC|1.4.1 vscode-highlight|fab|1.9.0 vscode-firefox-debug|fir|2.9.10 auto-rename-tag|for|0.1.10 copilot|Git|1.172.758 copilot-chat|Git|0.13.0 remotehub|Git|0.62.0 vscode-pull-request-github|Git|0.82.0 triggertaskonsave|Gru|0.2.17 vscode-htmlhint|HTM|1.0.5 reg|ion|1.1.0 vscode-peacock|joh|4.2.2 minifyall|jos|2.10.0 node-module-intellisense|lei|1.5.0 Lisp|mat|0.1.12 render-crlf|med|1.8.0 vscode-language-babel|mgm|0.0.40 git-graph|mhu|1.30.0 line-journey-undo|MKM|0.0.1 vscode-filesize|mkx|3.1.0 vscode-apache|mrm|1.2.0 debugpy|ms-|2024.2.0 isort|ms-|2023.10.1 python|ms-|2024.2.1 vscode-pylance|ms-|2024.2.3 extension-test-runner|ms-|0.0.6 hexeditor|ms-|1.9.14 js-debug-nightly|ms-|2024.3.417 live-server|ms-|0.4.13 remote-repositories|ms-|0.40.0 test-adapter-converter|ms-|0.1.9 debugger-for-edge|msj|1.0.15 color-highlight|nau|2.5.0 vscode-auto-scroll|pej|1.2.0 vscode-versionlens|pfl|1.9.2 vscode-phpunit|rec|3.2.2 vscode-xml|red|0.26.1 format-html-in-php|rif|1.7.0 LiveServer|rit|5.7.9 vs-code-prettier-eslint|rve|6.0.0 multi-command|ryu|1.6.0 vbsvscode|Ser|1.2.1 swapdiff|sha|0.2.2 comment-divider|sta|0.4.0 code-spell-checker|str|3.0.1 vscode-stylelint|sty|1.3.0 svelte-vscode|sve|108.3.1 tabnine-vscode|Tab|3.76.0 tauri-vscode|tau|0.2.6 pdf|tom|1.2.2 vscode-ltex|val|13.1.0 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.2.30 vscode-wakatime|Wak|24.4.0 vscode-backup|Wes|0.0.6 eno|Wsc|2.3.53 php-debug|xde|1.34.0 local-history|xyz|1.8.1 json-color-token|yec|1.3.3 html-css-class-completion|Zig|1.20.0
alexr00 commented 8 months ago

@rzhao271 I should be able to check if the settings editor is already open somewhere and just surface it if so. Should I do this, or do you think this is a bug that the settings editor should handle?

vanowm commented 2 months ago

I think at the moment the best approach is to open release notes in a browser. This way you can switch between editors and settings without worrying about losing scroll position at release notes.