search

microsoft / vsts-cordova-tasks

Streamline CI setup for your Apache Cordova, PhoneGap, Ionic, or Cordova CLI compatible app using a set of useful pre-defined build steps for VS Team Services or TFS
http://go.microsoft.com/fwlink/?LinkID=691188
Other
25 stars 27 forks source link

Add node version management #23

Closed ryuyu closed 8 years ago

ryuyu commented 8 years ago

Adds node version management to all the tasks so that we run the correct node version that is required for each Cordova version.

@Chuxel @lostintangent

Chuxel commented 8 years ago
Chuxel commented 8 years ago

One thing that makes me a bit nervous here is we're spinning up a different version of node and executing the task and still referencing vsts-task-lib. Right now the agent appears to dynamically replace the library so it's possible and entirely likely that it will stop working on Node 0.12.x sometime in the near future. We likely need to do the getInput calls in the other node module and pass them to the execution module as something like command line args.

BretJohnson commented 8 years ago

This did LGTM, btw, as of yesterday's review.