Revert `[RetVal]` annotation for multi-output `DCompositionGetStatistics()`

microsoft / win32metadata

Tooling to generate metadata for Win32 APIs in the Windows SDK.

Other

1.34k stars 118 forks source link

Revert `[RetVal]` annotation for multi-output `DCompositionGetStatistics()` #1980

Closed MarijnS95 closed 2 months ago

MarijnS95 commented 2 months ago

For https://github.com/microsoft/win32metadata/pull/1970#discussion_r1733456988

This function returns multiple values via multiple mutable pointer arguments, besides the annotated frameStats parameter not being the last parameter.

Revert it because it has no effect on windows-rs and could even break in the future, because it's not intended to be used this way.

mikebattista commented 2 months ago

Seems reasonable to me if it adds value for projections that choose to honor it.

riverar commented 2 months ago

@mikebattista I don't think this merged correctly or was ready for merge. Am only seeing a .txt file change?

mikebattista commented 2 months ago

I see that too even though there was an emitter settings change as well. I'll fix it.