search

microsoft / winget-cli

WinGet is the Windows Package Manager. This project includes a CLI (Command Line Interface), PowerShell modules, and a COM (Component Object Model) API (Application Programming Interface).
https://learn.microsoft.com/windows/package-manager/
MIT License
23.37k stars 1.45k forks source link

NASM is not added to path when installed #2452

Open Stadly opened 2 years ago

Stadly commented 2 years ago

Brief description of your issue

When installing NASM, it is not added to the path.

Steps to reproduce

  1. winget install -e --id NASM.NASM
  2. Investigate the path environment variable to see if NASM is there

Expected behavior

  1. NASM is installed
  2. NASM is added to path

Actual behavior

  1. NASM is installed
  2. NASM is not added to path

Environment

Windows Package Manager v1.3.2091
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.795
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.2091.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
denelon commented 2 years ago

@Stadly unless NASM.NASM is a portable package, the installer would be responsible for adding the package to the path. If it is adding it to the path, restarting the terminal would be necessary to get the environment variables refreshed for that session.

Trenly commented 2 years ago

This is very much related to #2453 and my subsequent response regarding what the NASM installer actually does. Because winget doesn't explicitly control the default install location, and the fact that users may be able to override install locations with the --location flag if the installer supports it, this is the responsibility of the NASM team to implement into their installer

Trenly commented 2 years ago

@denelon - Beat me by seconds again!!

Stadly commented 2 years ago

This seems to be an old issue: https://bugzilla.nasm.us/show_bug.cgi?id=3392224