search

microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.32k stars 4.26k forks source link

[Package Request]: Ghidra #111394

Open AsciiWolf opened 1 year ago

AsciiWolf commented 1 year ago

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

Please provide the following information

Download Page Url: https://github.com/NationalSecurityAgency/ghidra/releases Publisher: National Security Agency Package Name: Ghidra Description: A software reverse engineering (SRE) suite of tools developed by NSA's Research Directorate in support of the Cybersecurity mission. Package Version: 10.3.1 Installer URL: https://github.com/NationalSecurityAgency/ghidra/releases/download/Ghidra_10.3.1_build/ghidra_10.3.1_PUBLIC_20230614.zip

Trenly commented 1 year ago

The "installer" is a .bat script which goes against the policy of no scripts.

[Policy] Blocking-Issue

AsciiWolf commented 1 year ago

As far as I know, it is not an installer, but a launcher. Ghidra does not have an installer, it acts as a portable app.

Trenly commented 1 year ago

As far as I know, it is not an installer, but a launcher. Ghidra does not have an installer, it acts as a portable app.

Either way, it is still a bat script and not an executable. It is one of the core principles of WinGet not to allow scripts during install (which includes portable app installs). You can read more about it in the Scripts discussion

upintheairsheep commented 11 months ago

I have attempted to add this into winget in the past

smcnabb1 commented 5 months ago

Not sure if this helps get it added but the "installation" of ghidra is just downloading the latest .zip and unzipping it to a folder. There is no install.exe or installer script that needs to be ran.

Winget would just need to get the ghidra.zip -> unzip to program files or something and that would be considered installing ghidra

colejohnson66 commented 2 months ago

The "installation" of deno is the same way, so there's precedent for non-installer tools. Specifically, it downloads a ZIP file that contains a single file, then extracts it:

https://github.com/microsoft/winget-pkgs/blob/1ef044878b41819fac8efdee86d4d30c84253857/manifests/d/DenoLand/Deno/1.42.4/DenoLand.Deno.installer.yaml#L4-L16

The purpose of adding Ghidra would be to allow winget to manage updates for the user.