search

microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.76k stars 4.58k forks source link

EclipseAdoptium.Temurin - Split into `.jdk` and `.jre` #67708

Closed russellbanks closed 2 years ago

russellbanks commented 2 years ago

The EclipseAdoptium.Temurin packages are currently split as two separate packages: EclipseAdoptium.Temurin and EclipseAdoptium.TemurinJRE. I feel like it would be beneficial if, for clarity, the packages matched more like the ojdkbuild packages on here. (Shown below)

WindowsTerminal_kJHegjjDx6

This would mean moving the packages (using Adoptium 17 as an example):

EclipseAdoptium.Temurin.17 -> EclipseAdoptium.Temurin.17.JDK EclipseAdoptium.TemurinJRE.17 -> EclipseAdoptium.Temurin.17.JRE

This makes the more sense as both packages come from the same GitHub releases and it also means that they will all be listed in numerical order, making it easier for the user to find the version, and then choose the variation:

EclipseAdoptium.Temurin.8.JDK EclipseAdoptium.Temurin.8.JRE EclipseAdoptium.Temurin.11.JDK EclipseAdoptium.Temurin.11.JRE

Rather than:

EclipseAdoptium.Temurin.8 EclipseAdoptium.Temurin.11 EclipseAdoptium.TemurinJRE.8 EclipseAdoptium.TemurinJRE.11


If this is an acceptable change (best for a moderator to say so), then I'm happy to do this myself.

Trenly commented 2 years ago

I'm Trenly and I approve this message

vedantmgoyal9 commented 2 years ago

Please assign this to me since the InstallerUrls are so messed up in some manifests. I'll do it along with fixing it in the automation, on or by this Friday.

Also, I think EclipseAdoptium.Temurin.<jre/jdk>.<version> is more preferable than EclipseAdoptium.Temurin.<version>.<jre/jdk>. Rest whatever mods decide.

Edit: To keep the naming consistent across the repo, original post is correct.

cc @russellbanks

russellbanks commented 2 years ago

Please assign this to me since the InstallerUrls are so messed up in some manifests. I'll do it along with fixing it in the automation, on or by this Friday.

No problem; it's all yours :)

russellbanks commented 2 years ago

Also, I think EclipseAdoptium.Temurin.<jre/jdk>.<version> is more preferable than EclipseAdoptium.Temurin.<version>.<jre/jdk>. Rest whatever mods decide.

Edit: To keep the naming consistent across the repo, original post is correct.

Although this wouldn't match ojdkbuild, I agree that it is more preferable to have it like EclipseAdoptium.Temurin.<jre/jdk>.<version> because it makes the most sense to have the version number last. Also, you'd end up with a lot of folder redundancy with each major version having a sub JDK and JRE folder so this way would mean the folder structure could just go EclipseAdoptium -> Temurin -> <jdk/jre> -> version.

vedantmgoyal9 commented 2 years ago

I've opened for JDK. Once they get merged, I'll do JRE.

russellbanks commented 2 years ago

Is it possible you could add Temurin 19 and Temurin 20, please. They're both JDK only and in beta so it may be worth putting Eclipse Temurin JDK with Hotspot 19 (Beta) and Eclipse Temurin JDK with Hotspot 20 (Beta). It should only be one manifest for each as the version number won't change until it's released.

vedantmgoyal9 commented 2 years ago

I guess you've already added them to the repo. https://github.com/microsoft/winget-pkgs/tree/master/manifests/e/EclipseAdoptium/Temurin/

russellbanks commented 2 years ago

@vedantmgoyal2009 is there any update on the JRE packages?

vedantmgoyal9 commented 2 years ago

I will open PRs for them today midnight IST.

russellbanks commented 2 years ago

Thanks again @vedantmgoyal2009 :)