microsoftarchive / http2-katana

HTTP 2.0 with Katana
133 stars 34 forks source link

Compression: incorrect headers size #57

Closed squirrelfm closed 10 years ago

squirrelfm commented 10 years ago

Actual : name.Len + value.Len + sizeof(Int32) Should be : name.Len + value.Len + 32
Because (03 compr spec):

The size of an entry is the sum of its name's length in bytes (as defined in Section 4.1.2), of its value's length in bytes (Section 4.1.3) and of 32 bytes. The 32 bytes are an accounting for the entry structure overhead. For example, an entry structure using two 64-bits pointers to reference the name and the value and the entry, and two 64-bits integer for counting the number of references to these name and value would use 32 bytes.

squirrelfm commented 10 years ago

Fixed by f153d8297c63ec65b67f3acf06acca7eb0c31429