Closed MichaMican closed 1 month ago
Thanks @MichaMican for using the SDK and for requesting this, considering your use case, I see it as a positive to add requestId field as an optional parameter to batch requests. Feel free to contribute a PR to this
I have opened a PR (#887) with my proposed changes :)
Is your feature request related to a problem? Please describe the problem.
When doing batch calls i sometimes use a custom requestId. For example if i want to request some group information for multiple different groups, i used the groupId as a requestId in the past to simply get the correct response from the body without the need to have to map a generated requestId to a groupId
Describe the solution you'd like.
The Method
AddBatchRequestStepAsync
insideBatchRequestContent.cs
is generating the requestId. This method should have an optional requestId paramter which should get passed up so to theAddBatchRequestStepAsync
ofBatchRequestContentCollection.cs
function.so basically i would propose to have
AddBatchRequestStepAsync
inBatchRequestContentCollection.cs
look like this:and
AddBatchRequestStepAsync
inBatchRequestContent.cs
look like this:This solution would also be backwords compatible, meaning it has no breaking changes because the new
requestId
parameter ofAddBatchRequestStepAsync
is optionalAdditional context?
If not already in development somewehere & it's agreed that this is in scope for the library i can open a PR with the proposed changes from above