method.IsNil() panics and the actual error is never returned

[manisharma]

Overview

Generic func convertToPage[T interface{}](response interface{}) (PageResult[T], error) method uses IsNil() method from reflect package eg: method.IsNil() to check if the response argument is Nil and as a result it panics and the actual/intended error is never returned. The PR addresses the panic, by replacing method.IsNil() check with method.Kind() == reflect.Invalid

[manisharma]

Thanks for the contribution. Would you mind adding a unit test to prevent future regressions please?

Done.

[manisharma]

@microsoft-github-policy-service agree

[baywet]

@manisharma your last changes are failing to test, would you mind taking another look before I review the changes please?

[manisharma]

pre-existing tests are failing @baywet

[baywet]

@manisharma it isn't on main if some additional unit tests are failing because of the change you've made, please update them.

[manisharma]

Yes thanks. I deleted pre-existing setup unknowingly. @baywet