Batch "response" semantics are confusing

microsoftgraph / msgraph-sdk-go-core

Microsoft Graph SDK for Go - Core Library

https://learn.microsoft.com/graph/sdks/sdks-overview

MIT License

20 stars 10 forks source link

Batch "response" semantics are confusing #250

Open eric-millin opened 1 year ago

eric-millin commented 1 year ago

Not a huge deal, but something to think about for v2.

The Batch API is confusing when dealing with BatchItem and BatchResponse. Response is overloaded as it refers to both the response to the top-level batch response and the collection of responses that it contains. Then GetResponses returns BatchItem. Functions operating on the BatchItem treat it as a "response". I've had moments of trying to keep everything straight. Could use clarifying. Thanks

eric-millin commented 1 year ago

Occurred to me that distinguishing Batched items from Batch might help.