microsoftgraph / msgraph-sdk-serviceissues

Tracks service issues for follow up.
5 stars 0 forks source link

IDriveItemInviteRequestBuilder parameter expirationDateTime is defined as string; should be DateTimeOffset? #110

Open dancampbell691 opened 3 years ago

dancampbell691 commented 3 years ago

Expected behavior

in 3.33, the signature for IDriveItemInviteRequestBuilder is as follows: IDriveItemInviteRequestBuilder Invite(IEnumerable<DriveRecipient> recipients, bool? requireSignIn = null, IEnumerable<string> roles = null, bool? sendInvitation = null, string message = null, **string expirationDateTime** = null, string password = null);

No string representation of a date seems to work. However, IDriveItemCreateLinkRequestBuilder is defined nearby as: IDriveItemCreateLinkRequestBuilder CreateLink(string type, string scope = null, **DateTimeOffset? expirationDateTime** = null, string password = null, string message = null);

That seems to work fine when a DateTimeOffset (not string) is passed in. So I believe there is a mistake in the signature for IDriveItemInviteRequestBuilder. expirationDateTime should be a DateTimeOffset in that instance as well.

AB#9746

andrueastman commented 3 years ago

Thanks for raising this issue @dancampbell691.

According to the metadata we use to generate the sdk here, the property seems to be defined as String which is inconsistent with the docs here.

image

We will need to follow up to have this fixed in the metadata.

andrueastman commented 3 years ago

It looks like this is mainly a service issue. According to the following links, the API does not currently support the expirationDateTime parameter at the moment.

petrhollayms commented 5 months ago

Thank you for reporting this issue. This appears to be an issue or limitation with the service APIs. Unfortunately, as the Microsoft Graph SDK team, we do not have ownership of the APIs that are causing you issues. We invite you to create a question about the service API to Microsoft Q&A and tagged with one of the [microsoft-graph-*] tags, that way it will get routed to the appropriate team for them to triage:

https://aka.ms/msgraphsupport or directly https://aka.ms/askgraph

For now, we will close the issue on our side but feel free to open it in the relevant repository if you think the issue is specific to SDK. Please let us know if this helps!

Note: We will close this repository on April 19, 2024.