search

midstar / heatmiser_wifi

Heatmiser WiFi Thermostat communication library for python
MIT License
1 stars 6 forks source link

Additional Thermostats #6

Open tcruiser60 opened 2 weeks ago

tcruiser60 commented 2 weeks ago

Hi Ian Thank you for work on the Libuary, I was wondering if we could include the TM1 as well please. I think it's a relativly simple change to the code, I had already modified the original libuary to included it but your version adds extra feature and is well better code.

But the changes are minimal
heatmiser_wifi_1_4.txt

essentially it adds the extra definition - 

    elif(self.modelNumber == 5):
        info["model"] = "TM1"

And modifies the extra parameter selection to be 

    # Model PRT-HW has extra fields and offsets for the rest
    if(self.modelNumber < 4):

rather than
if(self.modelNumber != 4):

in both sections that specifie the code for PRT thermostats.

thank you cheers Tim

midstar commented 1 week ago

Hi,

Of course, but please submit a pull-request with your suggested changes.

BR, Joel