mifi / lossless-cut

The swiss army knife of lossless video/audio editing
https://losslesscut.app/
GNU General Public License v2.0
28.16k stars 1.37k forks source link

AppImage does not provide a valid icon for linux desktop integration. #2237

Open ensonic opened 2 weeks ago

ensonic commented 2 weeks ago

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Operating System

Linux

Steps to reproduce

./appimagelint-x86_64.AppImage LosslessCut-linux-x86_64.AppImage
...
ppimagelint.cli[21500] [INFO] Running check "Icons validity and location check"
appimagelint.icons_check[21500] [INFO] Extracting icon name from desktop file: /tmp/.mount_LosslesTZwTf/losslesscut.desktop
appimagelint.icons_check[21500] [INFO] Checking resolution of icon: /tmp/.mount_LosslesTZwTf/losslesscut.png
appimagelint.icons_check[21500] [INFO] [✔] Valid icon in AppDir root
appimagelint.icons_check[21500] [INFO] Checking resolution of icon: /tmp/.mount_LosslesTZwTf/.DirIcon
appimagelint.icons_check[21500] [INFO] [✔] Valid icon file in .DirIcon
appimagelint.icons_check[21500] [INFO] Checking resolution of icon: /tmp/.mount_LosslesTZwTf/usr/share/icons/hicolor/0x0/apps/losslesscut.png
appimagelint.icons_check[21500] [ERROR] Icon resolution doesn't match resolution in path: (0, 0) (file resolution is (512, 512))
appimagelint.icons_check[21500] [WARNING] no other icons found
appimagelint.icons_check[21500] [INFO] [✖] Other integration icons valid

Expected behavior

I am using https://github.com/TheAssassin/AppImageLauncher and I would expect an icon with the desktop entry.

Actual behavior

Fallback icon used.

Share log from developer tools

See log in repro. Tool used: https://github.com/TheAssassin/appimagelint

ensonic commented 2 weeks ago

I did a bit more research, and this is actually: https://github.com/electron-userland/electron-builder/issues/5294