wasted space bellow bottom nav bar

doudoud82 commented 1 month ago

Steps to reproduce

Update to the latest mihon beta release after r6916.

Expected behavior

expecting the app to look like this: Screenshot_20241015-193557_Mihon Screenshot_20241015-193549_Mihon

Actual behavior

the app looks like this: Screenshot_20241015-193015_Mihon Screenshot_20241015-192954_Mihon Screenshot_20241015-193001_Mihon

Crash logs

No response

Mihon version

Beta r6938

Android version

Android 8

Device

Samsung S7

Other details

I noticed this today when updating tachiyomiSY preview build r566 and got advised to report it to mihon. upon further investigation, I found out that Mihon Preview r6916 doesn't exhibit this behaviour whereas newer builds do. Also when reading a chapter this wasted space doesn't appear and the screen is used fully.

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

MajorTanya commented 1 month ago

Just to be clear, you were using r6916 and then updated to latest, r6938? Did you also observe this in the intermediate r6926?

doudoud82 commented 1 month ago

Just to be clear, you were using r6916 and then updated to latest, r6938? Did you also observe this in the intermediate r6926?

I am using TachiyomiSy mainly in today's update I noticed this and when talked about it in Discord I got recommended to report the issue to Mihon. I decided to check if the problem is in Mihon too(otherwise it is not worth reporting here) and I found that the build r6916 doesn't have this problem while any newer build after it does have it. in other words, r6926 also has this behaviour; and r6916 is the oldest build I tested that didn't exhibit it. I did this to potentially help identify which change caused it.

MajorTanya commented 1 month ago

Just to be clear, you were using r6916 and then updated to latest, r6938? Did you also observe this in the intermediate r6926?

I am using TachiyomiSy mainly in today's update I noticed this and when talked about it in Discord I got recommended to report the issue to Mihon. I decided to check if the problem is in Mihon too(otherwise it is not worth reporting here) and I found that the build r6916 doesn't have this problem while any newer build after it does have it. in other words, r6926 also has this behaviour; and r6916 is the oldest build I tested that didn't exhibit it. I did this to potentially help identify which change caused it.

Thanks, that'll be helpful in narrowing it down 👍

MajorTanya commented 1 month ago

Could you tap the "Version" field in the More view and paste the copied data here?

Edit: Could you also share one (1) screenshot of the Good and Bad version with a different theme? The Amoled themes makes it impossible to differentiate empty black space from "it's background-coloured"

doudoud82 commented 1 month ago

Could you tap the "Version" field in the More view and paste the copied data here?

No problem. App version: 0.16.5-6938 (standard, 2e2c8d36c, 7, 2024-10-14T23:03:33Z) Android version: 8.0.0 (SDK 26; build ALEXNDR.G930FXXU8EUE1) Device brand: samsung Device manufacturer: samsung Device name: herolte (heroltexx) Device model: SM-G930F WebView: Chrome 129.0.6668.100

MajorTanya commented 1 month ago

Okay, so. I checked the "good" and "bad" versions in an Android 8.0.0 emulator with the screen dimensions set to whatever the S7 has. I cannot replicate this problem.

It also doesn't seem to exist on more current devices, both in emulation as well as actual installs.

I'm not sure why it appears for you. Some remaining ideas:

Did you try force closing the app and restarting it?
Did you try to change the theme to something else? If yes, and the issue persists, please provide one (1) screenshot of only the bad version and please Do Not use the Amoled/Pure Black mode for that
Did you try uninstalling Mihon and reinstalling it? Maybe something went weird during the update/install process?

doudoud82 commented 1 month ago

Did you try force closing the app and restarting it?

no, I mainly use TachiSy as I said previously and this behaviour is happening on a fresh install of mihon preview.

Did you try to change the theme to something else? If yes, and the issue persists, please provide one (1) screenshot of only the bad version and please Do Not use the Amoled/Pure Black mode for that

Here is a screenshot for when disabling pure black. Screenshot_20241015-210130_Mihon

Did you try uninstalling Mihon and reinstalling it? Maybe something went weird during the update/install process?

I reinstalled it a couple of times since I switched between multiple versions(mainly r6938 r6926 r6916) to check from which version this started to happen.

MajorTanya commented 1 month ago

Very weird. As I said, I can't reproduce this in an emulator and I don't have a real S7 at hand. I'll leave the issue open in case someone else figures something out.

doudoud82 commented 1 month ago

understandable unless it is possible to replicate the behaviour it will be impossible to attempt to fix something that cannot be replicated to test and such. this video shows the 3 versions I redownload and reinstalled.

https://github.com/user-attachments/assets/5671074b-6c8c-4ef6-bb11-974741280d51

either way, I guess this will be on hold till more info or it can be reproduced since it doesn't affect when reading chapters only UI. Have a nice day.

nobSEIFO commented 3 weeks ago

I noticed that if I clicked on anything that triggers the keyboard to appear it will fix the problem until I restart the app https://github.com/user-attachments/assets/ee749dfb-cf1d-460b-9a4f-d33cc7f4b772

doudoud82 commented 3 weeks ago

@nobSEIFO rather interisting didn't notice this behavior before, thanks for the info.

CatGamer23 commented 2 weeks ago

I believe that is a common issue in Android, where if you have the gesture mode of navigation and the pill? bar? is hidden, it will occasionally cause apps to have gaps. This was a common occurrence with my Pixel 7. Android 15, however, fixes this gap issue. Though, this does not explain why a specific version does/doesn't have the gap. The only explanation I have for that is if the Android API version was increased, which caused the apps to register as a newer one, which, from my observations, seem to have this issue more often.

MajorTanya commented 2 weeks ago

This is most likely down to us removing a deprecated UI library that handled displays of older Android versions differently. We didn't increase the SDK version or anything like that (people with Android 8 wouldn't be able to install it at all in that case).

CatGamer23 commented 2 weeks ago

Ah, okay, that makes more sense.

nobSEIFO commented 6 days ago

@MajorTanya is there any fix planned for this issue , or it will be left as it is

MajorTanya commented 6 days ago

@MajorTanya is there any fix planned for this issue , or it will be left as it is

Don't comment unless you have something to contribute to the issue, please. We'll find a fix when we find it.

CatGamer23 commented 6 days ago

While I am no Android developer, I do have some limited knowledge when it comes to Android development, so please take what I say with a grain of salt. I looked through the AndroidManifest.xml and traced my way back up the various style/theme declarations, and am noticing, that android:windowFullscreen is missing, like mentioned in this Stack Overflow thread. I am assuming it is inheriting form here which inherits this which does not include the fullscreen tag? style? in it:

<style name="Theme.Material3.Dark.NoActionBar">
    <item name="windowActionBar">false</item>
    <item name="windowNoTitle">true</item>
</style>

CatGamer23 commented 6 days ago

Would adding the line <item name="android:windowFullscreen">true</item> in line 9 of this potentially solve this?

BrutuZ commented 6 days ago

Would adding the line <item name="android:windowFullscreen">true</item> in line 9 of this potentially solve this?

I'm guessing that would hide the system status bar too (notifications, clock, battery), which is not desirable outside of the reader given the many features that rely on notifications during usage.

CatGamer23 commented 6 days ago

It does that anyway when reading, so I don't think there will be that much of an impact, and it can be turned into a toggle probably in the settings as well for those who want it. And either way, what features rely on notifications only @BrutuZ ? Because the only notifications I get is for downloads, and updated manga, which can both be viewed in-app in the downloads and library respectively.

And the updated manga notifications is more important outside of the app than inside imo.

BrutuZ commented 6 days ago

what features rely on notifications only

App updates. Library updates is kind of a big deal with the app on screen too, so you can tell if it didn't run at all because the process was killed or was just a quick flash mostly skipped due to Smart Updates

CatGamer23 commented 6 days ago

Again, neither of those are something you'd need in-app, like for app updates, either way you'd have to exit the app in order to update it, and library updates, well, its not like you can change it so know it went fast or not, it still checked.

mihonapp / mihon