mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
10.6k stars 485 forks source link

Add FOSS flavor #1448

Open papjul opened 2 weeks ago

papjul commented 2 weeks ago

This PR implements a FOSS flavor (i.e. with no proprietary dependencies) and builds it when a new version is tagged. It's a pre-requisite for #1 although publishing it on F-Droid is not mandatory (some users may want to use the FOSS flavor with the internal updater, or something else like Obtainium). Note that compared to Tachiyomi, the updater can be left enabled this time, if you choose to make reproducible builds (which is the recommended way to publish on F-Droid).

Notes:

AntsyLich commented 2 weeks ago

FOSS build setup can exist for F-Droid but I don't necessarily see a point of having them on GitHub.

papjul commented 2 weeks ago

FOSS build setup can exist for F-Droid but I don't necessarily see a point of having them on GitHub.

The point of having them on GitHub is to allow reproducible builds. Basically, you build and sign the release with your key, and F-Droid compares it with their own build. If they match, they will publish your release with your key. This makes the release process safer by making the developer sign the releases (and not F-Droid), while allowing F-Droid to still check for any tampering attempt.

Also:

some users may want to use the FOSS flavor with the internal updater, or something else like Obtainium

AntsyLich commented 2 weeks ago

FOSS builds can stay in a separate repo then similar to preview/beta

papjul commented 2 weeks ago

Good idea! Should I revert the changes from the .github directory and let you create the other repo?