mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
10.69k stars 491 forks source link

Re: Separate storage for backups and for downloads #1511

Closed schklom closed 4 days ago

schklom commented 4 days ago

Describe your suggested feature

The app now uses scoped storage meaning it will only have access to a single folder that user has granted access to. It's a requirement for targeting newer Android version.

Originally posted by @AntsyLich in https://github.com/mihonapp/mihon/issues/9#issuecomment-1893746188

I don't see anything in https://developer.android.com/training/data-storage/shared/documents-files#document-tree-access-restrictions that suggests that apps can only access one unique folder.

I use Tasker via Scoped Storage, and it frequently accesses multiple folders in the background. I'm not an Android pro, but it looks like there might be a misunderstanding. Is there?

This feature would be important to me, as my backup folder is nearing 1GB because of the downloads, and this is taking up a lot of unnecessary space on my cloud storage.

Other details

Sorry to create a new issue but you prevent additional comments on the previous one

Acknowledgements

Norsze commented 4 days ago

Sorry to create a new issue but you prevent additional comments on the previous one

We do have a Discord when one wants to discuss stuff. If your issue was closed then you should probably take your questions there rather than opening a bunch of new tickets to continue arguing. This is not a subReddit

Norsze commented 4 days ago

And no we have probably not misunderstood as you are number 7866 to ask this. And the correct documentation starts here https://developer.android.com/about/versions/11/privacy/storage not wherever you started

BrutuZ commented 4 days ago

This feature would be important to me, as my backup folder is nearing 1GB because of the downloads, and this is taking up a lot of unnecessary space on my cloud storage.

Mihon doesn't upload anything anywhere, so that's a you issue. You need to better manage your cloud synchronization tool by only uploading the autobackup sub-folder instead of the whole Mihon parent folder

schklom commented 4 days ago

@Norsze Wasn't aware of Discord, my bad Wasn't my issue I only opened one issue: this one I only found one issue about this. I linked it, and so did you. Do you mean this gets asked on Discord a lot?

@BrutuZ

You need to better manage your cloud synchronization tool by only uploading the autobackup sub-folder instead of the whole Mihon parent folder

I would, but it doesn't let me do that for now: https://github.com/newhinton/Round-Sync/issues/272

that's a you issue

Isn't the point of Github issues to raise issues? It's also not just a me issue: according to @Norsze this is a problem for a lot of people.

Norsze commented 4 days ago

I mean, you and a lot of people have asked and we have told them, same as you, this is Android now. And someone did ask just a few hours before you #1508

And yes the point is to raise issues, preferably issues that haven't been raised multiple times in the GitHub. Like when it already is closed it means it is closed and yours will be too, it's just an extra chore to come tell you "no" and close it, it won't really leave you with discussion opportunities. That's why Discord is better for that.

schklom commented 4 days ago

Got it

AntsyLich commented 3 days ago

Not sure why I said it's limited to one directory or if I meant something else. But the limit is actually much higher than that, while there is no clear documentation it was previously 128 files and directories which was later bumped on Android 11 or 12 (not sure) to 512 files and directories.

The reason I'm declining separate folder options is for ease of usage on my side. I may consider this in the future but it is not something I'm willing to do for the time being.