mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
9.23k stars 407 forks source link

Incognito mode doesn't use the incognito keyboard #316

Open sahilarora3117 opened 7 months ago

sahilarora3117 commented 7 months ago

Steps to reproduce

  1. Turn on incognito mode
  2. Click on any text field

Expected behavior

Keyboard should be in incognito mode

Actual behavior

Keyboard is in general mode and saves typing history

Crash logs

No response

Mihon version

App version: 0.16.3-6499 (standard, 139663acf, 4, 2024-01-29T20:34Z) Android version: 14 (SDK 34; build UQ1A.240105.004) Device brand: google Device manufacturer: Google Device name: panther (panther) Device model: Pixel 7 WebView: Android System WebView 122.0.6261.5

Android version

Android 14

Device

Pixel 7

Other details

No response

Acknowledgements

mm12 commented 1 month ago

I think this will be helpful to whoever is working on it: AppBar.kt probably where changes are needed stackoverflow on ImeAction stuff and on incognito stuff

Animeboynz commented 1 month ago

These too maybe but apparently its might be a compose issue Discord https://github.com/mihonapp/mihon/blob/a3dfd2efe6ace7a2a4d79bd09fb1a729989f1094/app/src/main/java/eu/kanade/tachiyomi/widget/TachiyomiTextInputEditText.kt#L21