search

mike-marcacci / node-redlock

A node.js redlock implementation for distributed, highly-available redis locks
MIT License
1.85k stars 173 forks source link

Version 5 release schedule #160

Open andrejleitner opened 2 years ago

andrejleitner commented 2 years ago

Is there a plan to release version 5 in the foreseeable future?

luin commented 2 years ago

Sorry if this is off-topic, ioredis has just released v5.0.0. I think it would be nice if this update could be added to v5 😄.

ehaynes99 commented 2 years ago

Will the current version work with ioredis 5? The type definitions don't quite match, but they're not actually correct anyhow. They define it as:

interface CompatibleRedisClient {
    eval(args: EvalArg[], callback?: (err: Error | null, res: any) => void): any;
}

Whereas in the 4.2 codebase, the only function called on the client is evalsha

wolfido92 commented 2 years ago

We want to upgrade to ioredis v5, will you update in the near future? We can help with the migration if you need anything.

anton-brass commented 2 years ago

Is there any update here? We have a library conflict with typeorm, which uses a newer version of io-redis, and we need to update to that.

palumbamboo commented 2 years ago

Hello guys, any news for the v5 release? Thanks

Nikamura commented 2 years ago

I have opened PR to potentially get this done. https://github.com/mike-marcacci/node-redlock/pull/231

ChrisZieba commented 1 year ago

@mike-marcacci Are you open to adding any maintainers of this project?

mike-marcacci commented 1 year ago

Hi @ChrisZieba, I would actually be very interested in that. This project continues to work well in the places where I have it deployed, and other responsibilities have prevented me from giving it much time that isn't directly related to those use-cases. There are some finer points about redlock that I'd need a maintainer to understand – a fair number of requests have come in around use patterns that are outside the scope of this tool and would be unsound, so I wouldn't want to make changes that encourage these.

I've avoided publishing a final v5 for far too long now... I think incorporating the miscellaneous fixes and improvements (and exploring a couple reported bugs) are long overdue, but this is a can I've obviously been kicking for far too long now.

Is this something you'd be interested in, or know someone who would be capable and willing to take that on?

mze9412 commented 1 year ago

Any news on this? :/

slavafomin commented 1 year ago

The weirdest thing is that the latest dist tag on npm points to the 5.0.0-beta.2 version (which is not even in the "releases" section on GitHub), while it should point only to a stable version, which should be 4.2.0 I guess.

Does it mean that the 5.0.0-beta.2 is actually stable? Is it safe to use it in production? Or is this just a publishing mistake?

develth commented 1 year ago

Release of 5.0.0-beta.2 was in March 2022. If it was an mistake, there was plenty of time to correct it. IMHO the Project looks like it´s dead.

djMax commented 1 year ago

I've rewritten this in more modern infra - ioredis5, TS, and vitest. Published as @sesamecare-oss/redlock. Happy to try and make a PR if it would be welcome.

https://github.com/sesamecare/redlock

yharaskrik commented 1 year ago

I've rewritten this in more modern infra - ioredis5, TS, and vitest. Published as @sesamecare-oss/redlock. Happy to try and make a PR if it would be welcome.

https://github.com/sesamecare/redlock

I heavily support this idea!

You could just open the PR regardless, then at least the community members in this thread could look and provide some feedback.

capaj commented 3 months ago

@djMax awesome work, someone should open a PR to deprecate this one