search

mikemag / snoCAD-X

CAD software for ski and snowboard design.
Apache License 2.0
36 stars 17 forks source link

allow large sidecut radius by avoiding integer overflow #11

Closed mholling closed 9 years ago

mholling commented 9 years ago

Hi!

This pull request is for a change which allows sidecut radius of greater than 46000mm. This is useful for skis with a small amount of sidecut (e.g. cross-country skis).

The current code contains lines which limit the sidecut radius to 46000 or less. This is because larger integer values overflow when squared, producing a negative argument for a Math.sqrt() call, resulting in NaN. I refactored the square root calculation to avoid this integer overflow. I was thus able to remove the 46000 upper limit on the radius value.

I'm not a Java coder so can't be sure there aren't other consequences of this change, but it all seem to work as intended for larger sidecut radius values.

Thanks!

splitn2 commented 9 years ago

hey @mholling thanks so much for joining in the fun! Are you on Skibuilders forum too? I'll let @danielgraf and @mikemag communicate with you about this and merging it into any future release etc ok they are busy guys but I am sure will be greatful for your input. We've just started to get traction on some teamwork and skills to enhance both SnoCAD-X and MonkeyCAM and its going to make both packages so much more useful. I'm especially fired up as my CNC is only weeks away from delivery now and it will be great to use these excellent apps in anger!!! cheers Rich

mholling commented 9 years ago

Hey @splitn2. No rush on this pull request as I have it working for my purposes. Just thought it might be useful to have in the official version somewhere down the line. I've just started lurking on SkiBuilders recently, and hoping to try building a ski once I have all the tools together. snoCAD-x looks like a great little tool.

splitn2 commented 9 years ago

@mholling have you got a cnc or access to one? If you have you might want to look at MonkeyCAM its a big head start for speeding up production. cheers

mholling commented 9 years ago

I wish! :) Not even got a table saw yet...

splitn2 commented 9 years ago

hey thanks for your contribution anyway. If it interests you please feel free to take an active part in this project. One objective we are working towards is a scenario where we are piping the configuration generated in SnoCAD-X into MonkeyCAM , so design visualisation to GCODE and cutting in a very short time. Added to that both SnoCAD-X and MonkeyCAM enhancements to spice up the options available for tip tail shapes etc...... So in the end this will be the small cnc enabled ski/board builders software of choice!

Something I am mulling over is a basic design for a cnc built from scraps that will do an accurate job of core and base cutting jobs outputted by this software. Using pipe or C-section channel for "linear rail" with belt drive for example, all out of recycled and/or cheap chinese components..... So we can get the small guys cnc enabled and more productive without breaking the bank.....