search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Remove the "Direct" doc-value format [LUCENE-8917] #914

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

This is the last user of the Legacy*DocValues APIs. Another option would be to move this format to doc-value iterators, but I don't think it's worth the effort: let's just remove it in Lucene 9?

Legacy Jira details

LUCENE-8917 by Adrien Grand (@jpountz) on Jul 15 2019, resolved Sep 05 2019 Linked issues:

mikemccand commented 5 years ago

+1 - I spent some time trying to convert this to iterators a few months back, and it's really not worth it.

[Legacy Jira: Alan Woodward (@romseygeek) on Jul 15 2019]

mikemccand commented 5 years ago

Commit 2a0c7a932a472215ec05d6c81e8d9c7608e3c250 in lucene-solr's branch refs/heads/master from Adrien Grand https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2a0c7a9

LUCENE-8917: Remove the Direct doc-values format.

[Legacy Jira: ASF subversion and git services on Sep 05 2019]

mikemccand commented 5 years ago

Commit ec0acf99849dbdb10be2c3df1dda387249696efc in lucene-solr's branch refs/heads/master from Adrien Grand https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ec0acf9

LUCENE-8917: Add MIGRATE entry.

[Legacy Jira: ASF subversion and git services on Sep 05 2019]

mikemccand commented 5 years ago

Commit 78b6530fb262a8b243b6383d9b2f9b6b2970c32f in lucene-solr's branch refs/heads/master from Adrien Grand https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=78b6530

LUCENE-8917: Fix test failure.

[Legacy Jira: ASF subversion and git services on Sep 05 2019]

mikemccand commented 5 years ago

this seems to have caused some reliable solr test failures?

Example... https://builds.apache.org/view/L/view/Lucene/job/Lucene-Solr-Tests-master/3683/

   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestCodecSupport -Dtests.method=testDynamicFieldsDocValuesFormats -Dtests.seed=FA28EF8B1D76D0FE -Dtests.multiplier=2 -Dtests.slow=true -Dtests.locale=ru -Dtests.timezone=Europe/Tiraspol -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] ERROR   0.04s J1 | TestCodecSupport.testDynamicFieldsDocValuesFormats <<<
   [junit4]    > Throwable #1: java.lang.IllegalArgumentException: An SPI class of type org.apache.lucene.codecs.DocValuesFormat with name 'Direct' does not exist.  You need to add the corresponding JAR file supporting this SPI to your classpath.  The current classpath supports the following names: [Asserting, Lucene70, Lucene80]
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([FA28EF8B1D76D0FE:1AFBB14D0BE866AA]:0)
   [junit4]    >        at org.apache.lucene.util.NamedSPILoader.lookup(NamedSPILoader.java:116)
   [junit4]    >        at org.apache.lucene.codecs.DocValuesFormat.forName(DocValuesFormat.java:108)
   [junit4]    >        at org.apache.solr.core.SchemaCodecFactory$1.getDocValuesFormatForField(SchemaCodecFactory.java:112)
   [junit4]    >        at org.apache.lucene.codecs.lucene80.Lucene80Codec$2.getDocValuesFormatForField(Lucene80Codec.java:74)
   [junit4]    >        at org.apache.solr.core.TestCodecSupport.testDynamicFieldsDocValuesFormats(TestCodecSupport.java:87)
...

..probably just some tests that need removed/updated to not try to use Direct as an option anymore?

[Legacy Jira: Chris M. Hostetter on Sep 05 2019]

mikemccand commented 5 years ago

Commit 2552986e8722e1e68cdde6a98ca9173d8c5341f2 in lucene-solr's branch refs/heads/master from Chris M. Hostetter https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2552986

LUCENE-8917: Fix Solr's TestCodecSupport to stop trying to use the now-removed Direct docValues format

[Legacy Jira: ASF subversion and git services on Sep 05 2019]

mikemccand commented 5 years ago

Thanks Hoss, I shouldn't have neglected to test Solr...

[Legacy Jira: Adrien Grand (@jpountz) on Sep 05 2019]

mikemccand commented 5 years ago

i think we're all good now – that looks like the only affected test.

[Legacy Jira: Chris M. Hostetter on Sep 05 2019]

mikemccand commented 5 years ago

Commit 2552986e8722e1e68cdde6a98ca9173d8c5341f2 in lucene-solr's branch refs/heads/jira/SOLR-13677_3 from Chris M. Hostetter https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2552986

LUCENE-8917: Fix Solr's TestCodecSupport to stop trying to use the now-removed Direct docValues format

[Legacy Jira: ASF subversion and git services on Sep 08 2019]

mikemccand commented 2 years ago

Closing after the 9.0.0 release

[Legacy Jira: Adrien Grand (@jpountz) on Dec 08 2021]