Again, to clarify, please don't bother yourself with this ticket on company time, on personal time you could be working on something that makes you money or improves the product for your feature personally.
This entire ticket is an afterthough. A look back at the code base that most people don't have the time for.
================
While true that using entrySet() is really only an improvement for traversing a TreeMap(at least that's how it was in JDK8), it's a good practice in general to use it over keySet(), if you then use that keyset to do an extra lookup to get the value as well as the key.
So that's what this ticket is.
All changes were done automatically via Intellij's built-in code analysis.
Putting this on LUCENE because code both in lucene and solr was changed.
Legacy Jira details
LUCENE-8975 by Koen De Groote (@KoenDG) on Sep 10 2019, resolved Sep 13 2019
Linked issues:
Simple, non-important code cleanup.
Again, to clarify, please don't bother yourself with this ticket on company time, on personal time you could be working on something that makes you money or improves the product for your feature personally.
This entire ticket is an afterthough. A look back at the code base that most people don't have the time for.
================
While true that using
entrySet()is really only an improvement for traversing a TreeMap(at least that's how it was in JDK8), it's a good practice in general to use it over keySet(), if you then use that keyset to do an extra lookup to get the value as well as the key.So that's what this ticket is.
All changes were done automatically via Intellij's built-in code analysis.
Putting this on LUCENE because code both in lucene and solr was changed.
Legacy Jira details
LUCENE-8975 by Koen De Groote (@KoenDG) on Sep 10 2019, resolved Sep 13 2019 Linked issues: