search

mikeoliphant / neural-amp-modeler-lv2

Neural Amp Modeler LV2 plugin implementation
GNU General Public License v3.0
229 stars 28 forks source link

Fix install target #30

Closed runiq closed 1 year ago

runiq commented 1 year ago

Hey, thank you for creating this! <3

The changes in this PR are required for building the plugin as a Flatpak, which is what I'm currently trying to do. The 'normal' build process will not be affected in any way.

The new DIRECTORY line makes installation work with any build directory, not just build. (Flatpak builds in a _flatpak_build directory instead of using build.)

Using a relative DESTINATION path honors CMAKE_INSTALL_PREFIX instead of hardcoding it to /usr. (Flatpak installs into /app/extensions/Plugins as a prefix.)

mikeoliphant commented 1 year ago

Seems fine to me. Thanks for the PR!