search

mikepultz / netdns2

Native PHP DNS Resolver and Updater
https://netdns2.com/
Other
119 stars 64 forks source link

PHP 7.4 compatibility: Fix parameter order of implode() #103

Closed AllenJB closed 4 years ago

AllenJB commented 4 years ago

As per the change notes on the manual page, the alternative parameter order is deprecated.

This was picked up when performing a scan on my project with the PHPCompatibility CodeSniffer extension.

Neither PHPCompatibility or a manual search found any other instances of implode() using the alternative parameter order.

mikepultz commented 4 years ago

Thanks @AllenJB - this has already been fixed, and will be included in the next release

AllenJB commented 4 years ago

@mikepultz Is that in an unpushed commit? master still shows the old version and I don't see any other code branches.

Do you have an estimate as to when the next release will be?