ci - Githubissues

mikesart / inotify-info

Linux inotify info reporting app

MIT License

280 stars 29 forks source link

ci #24

Closed motiejus closed 7 months ago

motiejus commented 7 months ago

Adding a simple github workflow. Main points:

remove the implicit dependency on /usr/bin/ld.gold. If we want that, it should be a config-like option in the Makefile. @mikesart can you help me understand why it's desirable in the first place?
fix the Dockerfile.
D_LIBCPP_DEBUG has been deprecated and replaced with D_LIBCPP_ENABLE_DEBUG_MODE in the clang version we use. I am not sure if we intend to run the debug build on ancient versions of gcc which do not have that option. Accepting feedback.

motiejus commented 7 months ago

You can preview a sample workflow run here: https://github.com/motiejus/inotify-info/actions/runs/7842103734

mikesart commented 7 months ago

I'm fine removing the gold linker entirely. I've used it in the past on other projects because it was significantly faster, but that obviously shouldn't matter for a project this small.

Would it be ok to just define _LIBCPP_DEBUG and _LIBCPP_ENABLE_DEBUG_MODE and have it work for old and newer versions?

motiejus commented 7 months ago

I'm fine removing the gold linker entirely. I've used it in the past on other projects because it was significantly faster, but that obviously shouldn't matter for a project this small.

Would it be ok to just define _LIBCPP_DEBUG and _LIBCPP_ENABLE_DEBUG_MODE and have it work for old and newer versions?

Done.