Changes to Complexes from Utah workshop

mikestillman / M2

The primary source code repository for Macaulay2

4 stars 2 forks source link

Changes to Complexes from Utah workshop #38

Closed mahrud closed 1 month ago

mahrud commented 4 months ago

This is a rebase of https://github.com/Macaulay2/M2/pull/3342 on top of your working branch.

These are changes to the Complexes package that I extracted from the Varieties branch from the recent workshop. Since Mike mentioned changes to the Complexes are happening now, I extracted these commits now, hoping to prevent a big merge conflict in the future.

fixed load paths in Complexes
removed calls to length Complex in resolutionMap
added formation for Ext modules in Complexes
fixed map(Complex, Complex, ZZ) to allow multiplication maps

cc: @mikestillman @ggsmith

mahrud commented 4 months ago

I reduced this to the four most straightforward commits that are directly related to Complexes. The rest can wait until the Varieties package is ready.

mikestillman commented 4 months ago

Thanks @mahrud, @ggsmith and I meet later this week, we will go through it then.

mahrud commented 2 months ago

Is this still being considered? Should I close it? Should I open it directly to the M2 repository?

mahrud commented 1 month ago

@mikestillman @ggsmith I updated this PR on top of complexes-pr-3 branch and added a bug fix for yonedaExtension and a test.

mikestillman commented 1 month ago

@mahrud Thanks for the fixes!

mahrud commented 1 month ago

By the way, your complexes-pr-3 branch is passing all tests now: https://github.com/mahrud/M2/actions/runs/11409540565 Should we open a pull request soon to give people whose packages were changed enough time to take a look?

mikestillman commented 1 month ago

@mahrud, thanks for the heads up on that. I have just created the pull request.