search

mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
11.46k stars 938 forks source link

pinterest error after dl several inmages #2273

Closed veneamin closed 2 years ago

veneamin commented 2 years ago

Successfully downloadinf several imges and after that got error:

C:\Programs\Gallery-dl>gallery-dl.exe --verbose https://www.pinterest.ru/veneamin0088/wine/ [gallery-dl][debug] Version 1.20.4 [gallery-dl][debug] Python 3.10.2 - Windows-10-10.0.19042-SP0 [gallery-dl][debug] requests 2.27.1 - urllib3 1.26.8 [gallery-dl][debug] Starting DownloadJob for 'https://www.pinterest.ru/veneamin0088/wine/' [pinterest][debug] Using PinterestBoardExtractor for 'https://www.pinterest.ru/veneamin0088/wine/' [urllib3.connectionpool][debug] Starting new HTTPS connection (1): www.pinterest.com:443 [urllib3.connectionpool][debug] https://www.pinterest.com:443 "GET /resource/BoardResource/get/?data=%7B%22options%22%3A+%7B%22slug%22%3A+%22wine%22%2C+%22usern ame%22%3A+%22veneamin0088%22%2C+%22field_set_key%22%3A+%22detailed%22%7D%7D&source_url= HTTP/1.1" 200 None [urllib3.connectionpool][debug] https://www.pinterest.com:443 "GET /resource/BoardFeedResource/get/?data=%7B%22options%22%3A+%7B%22board_id%22%3A+%2253128415598 1279945%22%7D%7D&source_url= HTTP/1.1" 200 None

During handling of the above exception, another exception occurred:

Traceback (most recent call last): File "C:\Users\Vinny\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\gallery_dl\job.py", line 77, in run self.dispatch(msg) File "C:\Users\Vinny\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\gallery_dl\job.py", line 121, in dispatch self.handle_url(url, kwdict) File "C:\Users\Vinny\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\gallery_dl\job.py", line 238, in handle_url if not self.download(url): File "C:\Users\Vinny\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\gallery_dl\job.py", line 361, in download return downloader.download(url, self.pathfmt) File "C:\Users\Vinny\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\gallery_dl\downloader\ytdl.py", line 42, in download module = ytdl.import_module(self.config("module")) File "C:\Users\Vinny\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\gallery_dl\ytdl.py", line 22, in import_module return import("youtube_dl") ModuleNotFoundError: No module named 'youtube_dl'

mikf commented 2 years ago

You need to have yt-dlp or youtube-dl installed to download from pins with videos in them, or you disable those with -o videos=false.

veneamin commented 2 years ago

You need to have yt-dlp or youtube-dl installed to download from pins with videos in them, or you disable those with -o videos=false.

i have both installed as standalone apps. Reinstalled with pip and now all works fine, thanks!

God-damnit-all commented 2 years ago

@mikf Not sure I like this change. I consider a ytdl failure to be something that needs to be addressed immediately. It may be that my version of yt-dlp is out of date and needs to be updated, but I may not know if gallery-dl doesn't make a fuss.

mikf commented 2 years ago

@ImportTaste This change only affects the error you get when there is no ytdl module to import. Everything else like option parsing and the actual download process stays the same. And there is still an error message, just not a fatal one that prevents downloads after it.

/tmp/pinterest/veneamin0088/Wine/pinterest_531284087302058044.png
[downloader.ytdl][error] Cannot import module 'youtube_dlp'
[download][error] Failed to download pinterest_531284087302058038.mp4
/tmp/pinterest/veneamin0088/Wine/pinterest_531284087302058036.jpg