Closed vsenderov closed 8 months ago
PR review:
@david-broman this one is now ready to merge as the requested additions in documentation have been created.
Can you the link to the issue for this PR that describes exactly how to reproduce the error? I.e. link to the exact TreePPL version, and DPPLversion, and Miking versions needed to reproduce the error?
Or, just provide hashes for the versions of the 3 repos. We really want to be able to reproduce this problem.
This is the issue https://github.com/treeppl/treeppl/issues/69
The issue is reproducible with the following hashes:
Miking: https://github.com/miking-lang/miking/commit/6fdd60d84ad8ac3e00f364929c87034e0edf6215 - this is the Miking PR that requires changes in DPPL, but does not include my overshadowing fix
Miking-DPPL: https://github.com/miking-lang/miking-dppl/commit/f4729bc3c6cc11d4d302a50e15d661dbac143e17 - this is the DPPL version that was fixed by Gizem
TreePPL: https://github.com/treeppl/treeppl/commit/34b794c93d2e8c3f730135ce064157aa6632db16 - this is the TreePPL version that was fixed by Gizem
Without this fix we get with the current miking/ miking-dppl stack
See also
https://github.com/treeppl/treeppl/pull/67