miking-lang / miking

Miking - the meta viking: a meta-language system for creating embedded languages
Other
51 stars 31 forks source link

Workaround for a Failing Test in TreePPL #829

Closed vsenderov closed 8 months ago

vsenderov commented 8 months ago

Without this fix we get with the current miking/ miking-dppl stack

viktor@yggy:~/Sync/Workspaces/TreePPL/treeppl$ make test
mi compile src/treeppl-to-coreppl/compile.mc --test
./compile | sed 's/\.\{10,\}//g'
NOTE: Zero-argument function, `hello`, converted to Int. Potential type errors might refer to Int type.

ERROR </home/viktor/Sync/Workspaces/Miking/miking/stdlib/tensor.mc 572:15-572:28>:
* Expected an expression of type: Option a
*    Found an expression of type: a1
* where
*   a :: Poly
* (errors: types Option a != a1)
* When type checking the expression
    else match x with None _ then None ()

.mi compile src/lib/standard.mc --test
./standard | sed 's/\.\{10,\}//g'

rm -f compile standard

See also

https://github.com/treeppl/treeppl/pull/67

vsenderov commented 8 months ago

PR review:

vsenderov commented 8 months ago

@david-broman this one is now ready to merge as the requested additions in documentation have been created.

david-broman commented 8 months ago

Can you the link to the issue for this PR that describes exactly how to reproduce the error? I.e. link to the exact TreePPL version, and DPPLversion, and Miking versions needed to reproduce the error?

david-broman commented 8 months ago

Or, just provide hashes for the versions of the 3 repos. We really want to be able to reproduce this problem.

vsenderov commented 8 months ago

This is the issue https://github.com/treeppl/treeppl/issues/69

vsenderov commented 8 months ago

The issue is reproducible with the following hashes:

Miking: https://github.com/miking-lang/miking/commit/6fdd60d84ad8ac3e00f364929c87034e0edf6215 - this is the Miking PR that requires changes in DPPL, but does not include my overshadowing fix

Miking-DPPL: https://github.com/miking-lang/miking-dppl/commit/f4729bc3c6cc11d4d302a50e15d661dbac143e17 - this is the DPPL version that was fixed by Gizem

TreePPL: https://github.com/treeppl/treeppl/commit/34b794c93d2e8c3f730135ce064157aa6632db16 - this is the TreePPL version that was fixed by Gizem