mikitex70 / redmine_drawio

Macro plugin to embed draw.io diagrams into Redmine wiki pages
MIT License
125 stars 51 forks source link

Buttons are switched #5

Closed rogerjak closed 8 years ago

rogerjak commented 8 years ago

Great plugin! The new toolbar buttons are wrong though; the dmsf one generates drawio_attach and the opposite for the other one. Also, the new embedded editor doesn't work for me, I think it's because we don't run redmine at root url, because of Bitnami. Thanks Roger

mikitex70 commented 8 years ago

Fixed. Thanks for reporting the issue.

rogerjak commented 8 years ago

Thanks, the buttons are ok now. But attach and edit still doesn't work. The placeholder is just a "missing image" and when I click save in the editor it tries to connect to the root so I get prompted for credentials and it all fails.

mikitex70 commented 8 years ago

I will look for your problem tonight, maybe there are other places where I need to inject the Redmine path. The prompt is normal, because the first time it needs to re-validate the user. It's strange the "missing image" for the placeholder. Sorry, I've tested it with a Bitnami installation but it seems I've not deeply tested it...

mikitex70 commented 8 years ago

I've tried Redmine in Bitnami and works fine for me. If you are using the DMSF plugin, make sure to enable its WebDAV capability in Read/Write mode to avoid an HTTP 502 error. Are you using Bitnami on Linux or Windows? If you are using the Windows version maybe the plugin has a problem in the path management. I will do a Windows test tomorrow. Try also to do a clean checkout of the plugin, and use the master branch as now is released. Maybe it can help.

rogerjak commented 8 years ago

(Bitnami Redmine 3.3.0.1 on Windows.)

After I click save in the editor and enter the credentials, the wiki page is updated with a new attachment. So far so good, but there's no diagram visible on the page, only the "missing image" thing.

Also, the page gets messed up, I have a plugin that automatically adds headers/footers to all wiki pages, and that "external text" is added to my page somehow.

mikitex70 commented 8 years ago

Hi rogerjak, I've pushed in the develop branch a new pre-release. This version should fix the problems running in Windows (tested with Bitnami 3.3.1-0 with Windows 7), plus some fix for Internet Explorer (tested with Internet Explorer 11). If you have troubles with the diagram editor (such as pages messed up), try using Firefox or Chrome.