Compatible to Redmine 4.1.0?

[ghost]

Hi,

Currently I use these redmine and redmine_drawio version: redmine: 4.1.0 redmine_drawio: v0.9.3

It worked well during setup progress and can start server as well. But when I tried to create a project, it return "Internal Error" with below log:

App 751 output: I, [2020-03-13T09:39:37.031571 #751]  INFO -- : Completed 500 Internal Server Error in 106ms (ActiveRecord: 17.0ms)
App 751 output: F, [2020-03-13T09:39:37.102502 #751] FATAL -- :   
App 751 output: F, [2020-03-13T09:39:37.102614 #751] FATAL -- : SystemStackError (stack level too deep):
App 751 output: F, [2020-03-13T09:39:37.102641 #751] FATAL -- :   
App 751 output: F, [2020-03-13T09:39:37.108742 #751] FATAL -- : plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'
App 751 output: plugins/redmine_emojibutton/lib/emojibutton_helper_patch.rb:39:in `heads_for_wiki_formatter_with_redmine_emojibutton'
App 751 output: plugins/redmine_drawio/lib/redmine_drawio/helpers/textile_helper.rb:33:in `heads_for_wiki_formatter'

Then I removed redmine_drawio and it worked well. So do you have any plans for upgrade plugin to work with redmine 4.1.0?

Thanks.

[mikitex70]

I've not tested Redmine 4.1.0. What I look is a stack overflow caused by a loop between redmine_drawio and the emojibutton plugins. From my experience this happens when a plugin uses a deprecated Rails method (incompatible from Redmine 3 and Redmine 4); I've worked around this in drawio_redmine but there are other plugins not ported to Rails 5 (used by Redmine 4). If you can post all installed plugins and their versions I can try to simulate (use Admin -> Info page). But you can also try to remove the redmine_drawio plugin and install other plugins; for example see issue #68. I suppose the bug is in the emojibutton plugin, but without a test I cannot confirm.

[ataraxus]

I've till now, no issues:

Environment:
  Redmine version                4.1.0.stable
  Ruby version                   2.6.5-p114 (2019-10-01) [x86_64-linux-musl]
  Rails version                  5.2.4.1
  Environment                    development
  Database adapter               Mysql2
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
Redmine plugins:
  easy_mindmup                   1.0
  easy_wbs                       1.5
  redmine_cors                   0.0.5
  redmine_drawio                 0.9.3
  redmine_openid_connect         0.9.4

[ataraxus]

btw. @mikitex70 Thanks for your work! I'm contributor in redmine_openid_connect ;)

[ghost]

Thanks for your work. I'll make some tests and let you know later.

[ghost]

Thanks a lot. We just checked again. Removed emojibutton is worked fine.