search

mikunn / openapi-schema-to-json-schema

Converts OpenAPI Schema Object to JSON Schema
75 stars 6 forks source link

Schema with format overwrites minimum and maximum values #35

Closed Lakitna closed 4 years ago

Lakitna commented 5 years ago

Closes #32

Will now only overwrite minimum and maximum values when:

  1. The value is not set. 0 is considered set.
  2. The value is outside the valid range (ex: maximum too big for int32)
Lakitna commented 5 years ago

Ready for merge on my end

ghost commented 4 years ago

Any chance this PR gets processed soon? Love this module and using it often, but this little bug impacts a lot in generating a fake payload from schema.

Lakitna commented 4 years ago

Paging @mikunn though I doubt it will help. Only 4 contributions in the last year...

Edit: If you do see this Mikunn; since you're not very active anymore, maybe you can make someone else maintainer? I'm willing to do it in any case.

mikunn commented 4 years ago

Hi @Lakitna,

First of all, thanks for the PR. I'm really sorry about the inactivity. I just haven't had any time to work on this.

The new, better home can be found at https://github.com/openapi-contrib/openapi-schema-to-json-schema with another maintainer. I'm certain your PR will be merged soon there.

I deprecated this package.

philsturgeon commented 4 years ago

Merged in new repo, you can close this.

philsturgeon commented 4 years ago

@mikunn maybe you could archive the repo and put a note in the description and README about the new repo?