fix pickling ServerDataStream and make it lazy

mila-iqia / fuel

A data pipeline framework for machine learning

MIT License

867 stars 268 forks source link

fix pickling ServerDataStream and make it lazy #386

Closed rizar closed 7 years ago

rizar commented 7 years ago

Two changes:

pickling an unpickled stream used to fail
I would really like ServerDataStream to postpone establishing the connection until it's really necessary for flexibility reasons. Also, it was kind of asymmetric so far that in during the construction it connects immediately but it doesn't so when unpickled.

dmitriy-serdyuk commented 7 years ago

I don't see where you call connect(). Should it lazily connect when you access context?

rizar commented 7 years ago

get_data() calls connect()

On Wed, 19 Apr 2017 at 11:48 dmitriy-serdyuk notifications@github.com wrote:

I don't see where you call connect(). Should it lazily connect when you access context?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mila-udem/fuel/pull/386#issuecomment-295318299, or mute the thread https://github.com/notifications/unsubscribe-auth/AAn8Yq3-SCd19Ay-pWmhKSPTLq8kf1oaks5rxizigaJpZM4NBraC .

dmitriy-serdyuk commented 7 years ago

Ok, LGTM then.