Twitter Client - Githubissues

milanbrahmbhatt commented 11 years ago

/cc @timothy1ee

milanbrahmbhatt commented 11 years ago

Fixed all the issues, and completed implementation. Feedback welcomed! /cc @timothy1ee

timothy1ee commented 11 years ago

Very nice work overall!

Be sure to try making the rows dynamic in height. It's a common requirement in iOS, so good to practice. If you try it, you'll find that your Auto Layout constraints for the image view are not correct.
Run your app using the 3.5" simulator and click on the Tweet view. You'll see an Auto Layout error in the console.
Good job reloading the twitter feed after the compose. A slightly better alternative would be to pass the created tweet back into the feed locally, so it'll be there immediately even with slow internet.
There's no way to delete a retweet or favorite.
Good job implementing pull to refresh.
In TimelineVC, you configure the navigation bar for the ComposeVC. The ComposeVC should configure its own navigation item.
In ComposeVC, be sure to avoid putting unnecessary properties and methods in the public header file.

The main takeaways for this homework were:

How to handle dynamically sized rows in table views.
How to implement and debug Auto Layout in the Tweet Cell, Compose view, and Tweet view.
How to implement nav stack and modal navigation.
How to augment a networking client.
How to augment a model, adding serialization/deserialization code, and formatting code.

Here's my checklist of things I'm looking at when I'm reviewing this project.

Is the Objective-C code styling consistent with standards?
Did you augment the API client with the methods for updating status, reply, retweet, favorite? Note that there is a separate endpoint for removing a retweet or favorite.
Did you augment the Tweet model? Note that for the embedded user, you should instantiate a User object and have the User class do the deserialization, instead of navigating to user.screen_name in the Tweet model.
Were the Auto Layout constraints correct for all the views?
Was the navigation implemented correctly either manually or via segues?
Was pull to refresh implemented?
Was infinite scrolling implemented?

milanbrahmbhatt / codepath