PHP8 incl PHP7.2+ - Githubissues

milesj / decoda

A lightweight lexical string parser for BBCode styled markup.

MIT License

196 stars 52 forks source link

PHP8 incl PHP7.2+ #150

Closed dereuromark closed 2 years ago

dereuromark commented 4 years ago

Resolves https://github.com/milesj/decoda/issues/148

Requires https://github.com/milesj/decoda/pull/149 to be released first as last minor of PHP5 support.

WIP for a while we can add more things here.

Since we do make a major here, we can add typehints.

TODO:

[x] unskip php8 run in travis matrix.
[ ] Add strict typehints (param and return)
[ ] Cleanup API? Is there anything that could be done in such a major - or deprecations to be removed?
[x] Fix getSmilies() to getSmileys()

milesj commented 4 years ago

Feel free to migrate this to GitHub Actions/CI if that works better.

dereuromark commented 4 years ago

It looks more like sth PHPUnit9+ related for some reason..

dereuromark commented 4 years ago

Yeah, now its green :) PHP 8 passes.

There was 1 warning:
1) Decoda\DecodaTest::testCustomConfigPath
The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageMatches() instead.

dereuromark commented 2 years ago

Should we merge and release a new minor if all is BC?

milesj commented 2 years ago

@dereuromark Go for it!