search

milkv-duo / duo-buildroot-sdk

Milk-V Duo Official buildroot SDK
411 stars 174 forks source link

Remove unused boards, architectures, and configs from u-boot #93

Closed Binary141 closed 6 months ago

Binary141 commented 6 months ago

There were a bunch of files and folders that don't seem relevant to this project, and don't seem to be needed in order to get the image built. I was able to build for the milkv-duo as the target using the build.sh script and boot from the resultant image and got output on the UART

carbonfix commented 6 months ago

Hi,

Thank you very much for your contribution and submitting a Pull Request to our project. We highly appreciate the efforts and suggestions from every contributor.

However, we believe that the changes made in the Pull Request, which only keep the currently used architecture and board files while removing other unrelated files, do not align with the usage and goals of the u-boot project. U-Boot is a powerful and flexible bootloader with extensive hardware support and portability. Preserving the complete codebase and file structure is crucial for maintaining and supporting multiple architectures and future expansions.

We encourage maintaining the cleanliness and maintainability of the codebase, ensuring the integrity of all relevant files. This helps ensure the stability, portability, and future development of the project. We suggest reconsidering and preserving the complete codebase to better meet the goals and requirements of the project.

We greatly appreciate your understanding and support. If you have any other suggestions or questions, we would be more than happy to further discuss them with you.

Thank you once again for your contribution!