search

milkypostman / powerline

emacs powerline
Other
790 stars 118 forks source link

@deb0ch: bug with commit d641caa #125

Open targzeta opened 8 years ago

targzeta commented 8 years ago

@deb0ch

I have just updated powerline with latest two commits, but see what it's happened:

Before: screenshot_1464594482

After (UTF-8 character undisplayed): screenshot_1464594537

Is it something wrong on my config?

Emanuele

deb0ch commented 8 years ago

Are you using emacs in a terminal (TTY) or in a X window (GUI) in your screenshots ?

What happened is that before there was an if statement to hide that UTF-8 character in GUI and only display it in TTY. I removed that if to display it both in TTY and GUI, but if you are indeed using GUI then I guess that condition was there for a reason.

It is supposed to look like this: vcs_glyph

I will work on a PR with a configuration variable to show or hide this in GUI.

In the mean time, you can go in powerline.el at line 446 and replace 

(defpowerline powerline-vc
  (when (and (buffer-file-name (current-buffer)) vc-mode)
          (format " %s %s" 
                  (char-to-string #xe0a0) 
                  (format-mode-line '(vc-mode vc-mode)))))

with 

(defpowerline powerline-vc
  (when (and (buffer-file-name (current-buffer)) vc-mode)
          (format " %s"
                  (format-mode-line '(vc-mode vc-mode)))))

which should stop showing that broken glyph altogether.

targzeta commented 8 years ago

I was within X window. Here how the powerline looks in a terminal: screenshot_1464680056

With your suggestion the broken glyph is disappeared.

Emanuele

deb0ch commented 8 years ago

126 should fix this