millejoh / emacs-ipython-notebook

Jupyter notebook client in Emacs
http://millejoh.github.io/emacs-ipython-notebook/
GNU General Public License v3.0
1.47k stars 122 forks source link

void-variable & circular dependency #606

Closed sam-s closed 4 years ago

sam-s commented 5 years ago

I see these on startup:

ein: [info] ein:crib-running-servers: (void-variable ein:jupyter-default-server-command)
ein: [info] ein:crib-token: (void-variable ein:jupyter-default-server-command)

because ein-notebooklist is required by ein-jupyter so it cannot require it so it compiles ein:jupyter-default-server-command as lexical.

There are two possible solutions:

  1. move (provide 'ein-jupyter) to the top and add (require 'ein-jupyter) to ein-notebooklist
  2. add (defvar ein:jupyter-default-server-command) to ein-notebooklist