search

millejoh / emacs-ipython-notebook

Jupyter notebook client in Emacs
http://millejoh.github.io/emacs-ipython-notebook/
GNU General Public License v3.0
1.47k stars 122 forks source link

add ein:quit to easily exit EIN without killing Emacs #622

Closed sam-s closed 4 years ago

millejoh commented 4 years ago

Thanks for the PR, @sam-s. Note sure if you are aware, but there is an ein:stop command which is aliased to ein:jupyter-server-stop and ein:jupyter-server-stop already has a call to ein:notebook-close-notebooks embedded into it.

That said I don't see any harm in adding another alias ein:quit.

Finally, are you seeing issues with notebooks not being closed when calling ein:jupyter-server-stop?

sam-s commented 4 years ago

I do not use ein-jupyter, so neither ein:stop nor ein:jupyter-server-stop are loaded by default. I updated the PR to reflect that. Thanks!