search

milvus-io / milvus-model

The embedding/reranking model zoo help user to convert their unstructured data into embeddings
Apache License 2.0
22 stars 17 forks source link

bgem3 devices kwargs syntax error bugfix #50

Closed SamSweere closed 4 days ago

SamSweere commented 5 days ago

Closes #49

wxywb commented 4 days ago

Thanks for fixing it. However, the argument should be "devices." I changed it to "device" (in fact, "devices" would also be fine) to make the interfaces of different models consistent. https://github.com/FlagOpen/FlagEmbedding/blob/777a9ac317cc07968ed0a7ce60c7cbcd85c36d92/FlagEmbedding/inference/embedder/encoder_only/m3.py#L57

SamSweere commented 4 days ago

Makes sense, thanks for merging it this quickly!