search

milvus-io / milvus-sdk-go

Go SDK for Milvus.
Apache License 2.0
354 stars 110 forks source link

fix: Make custom DialOption overwrite default ones #739

Closed congqixia closed 7 months ago

congqixia commented 7 months ago

See also #699

sre-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-go/blob/master/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
congqixia commented 7 months ago

/kind bug

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.94%. Comparing base (b8a1b6d) to head (a236ce4). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/739/graphs/tree.svg?width=650&height=150&src=pr&token=WJK43PV390&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #739 +/- ## ========================================== + Coverage 71.85% 71.94% +0.08% ========================================== Files 51 51 Lines 4758 4759 +1 ========================================== + Hits 3419 3424 +5 + Misses 1217 1212 -5 - Partials 122 123 +1 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/739?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [client/config.go](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/739?src=pr&el=tree&filepath=client%2Fconfig.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-Y2xpZW50L2NvbmZpZy5nbw==) | `71.92% <100.00%> (+0.50%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/739/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
ThreadDao commented 7 months ago

/lgtm