milvus-io / milvus-sdk-java

Java SDK for Milvus.
https://milvus.io
Apache License 2.0
397 stars 165 forks source link

fix concat expr error #1058

Closed Ice-YcY closed 2 months ago

Ice-YcY commented 2 months ago

concat expr error image

sre-ci-robot commented 2 months ago

Welcome @Ice-YcY! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉

Ice-YcY commented 2 months ago

/assign @xiaofan-luan

Ice-YcY commented 2 months ago

@yelusion2 @yhmo

yhmo commented 2 months ago

@Ice-YcY The DCO check is not passed. You can use "git commit --amend" to edit the commit, and include Signed-off-by: Author Name <authoremail@example.com> in the description.

By the way, could you cherry-pick another pr for the branch "2.4" and "2.3"?

Ice-YcY commented 2 months ago

add Signed-off-by & created another PR for 2.4 & 2.3

xiaofan-luan commented 2 months ago

/lgtm /approve

sre-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ice-YcY, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-java/blob/master/OWNERS)~~ [xiaofan-luan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xiaofan-luan commented 2 months ago

@Ice-YcY please update your tco