Open PwzXxm opened 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: PwzXxm
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
Attention: Patch coverage is 93.00000%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 82.94%. Comparing base (
61f73d5
) to head (9f6b887
). Report is 2 commits behind head on master.:exclamation: Current head 9f6b887 differs from pull request most recent head e7d1366
Please upload reports for the commit e7d1366 to get more accurate results.
Files with missing lines | Patch % | Lines |
---|---|---|
internal/proxy/search_util.go | 89.39% | 5 Missing and 2 partials :warning: |
rerun cpp-unit-test
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@PwzXxm go-sdk check failed, comment rerun go-sdk
can trigger the job again.
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
/hold
/unhold Rename iterator token to iterator id
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
/lgtm
/hold wait for inputs from @czs007 about backwards compatibility. New SDK -> Old Milvus Server
/unhold If the user uses New SDK and an old version of Milvus, the following message will show using pymilvus
The server does not support Search Iterator V2. Please upgrade your Milvus server, or create a search_iterator with use_v1=True instead
/run-cpu-e2e
New changes are detected. LGTM label has been removed.
@PwzXxm go-sdk check failed, comment rerun go-sdk
can trigger the job again.
@PwzXxm cpp-unit-test check failed, comment rerun cpp-unit-test
can trigger the job again.
issue: #37548